ref(errors): Unconditionally create a trace context#6009
Open
Dav1dde wants to merge 4 commits into
Open
Conversation
elramen
reviewed
May 20, 2026
3701903 to
0c4e69b
Compare
0c4e69b to
2f720e9
Compare
loewenheim
approved these changes
May 20, 2026
elramen
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to: #5979, removes the feature flag this was gated behind.
But with slightly different behaviour (in order of importane):
trace_idandspan_idfields, when they are created. This was already inconsistent between no trace context and a partial trace context. If any metadata is desired, we should add it to the context instead (if it gets created). Metadata for missing attributes is preserved (although I don't think that's that important).